feat(test): add schema tests #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfiel
force-pushed
the
schema-test
branch
from
ba1367c
to
5899ffe
Compare
|
you need to add the actual schema for the tests to work correctly. the stub has an empty schema so all the failing tests are failing. |
jeremyfiel
force-pushed
the
schema-test
branch
2 times, most recently
from
cd4dde2
to
0574b47
Compare
|
reminder :) |
|
Why should I add them to my PR? Wouldn't it be easier to merge my PR first, then you update your PR from |
ralfhandl
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Why actions. here and actions- in most of the other test files for actions?
jeremyfiel
force-pushed
the
schema-test
branch
from
0574b47
to
5226b62
Compare
jeremyfiel
force-pushed
the
schema-test
branch
from
5226b62
to
979384c
Compare
|
Closing this in favor of OAI#94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional schema tests for v1.0.0