Replace usleep with sleep #906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure seems unrelated. |
|
Seems like this should follow the other pull request you made and use c++'s sleep idiom. |
|
Ehhh it would make the line really long. usleep to sleep is simpler. |
|
There is the point of consistency, which makes refactoring in the future easier. And the point is to move from C api to standard C++. |
|
Done. |
|
Sorry, but you should make sure it compiles first. |
usleep was deprecated with POSIX 2008 and optionally unavailable with uClibc-ng.
|
Should be fixed now. |
|
Build failures are unrelated looks like. |
|
I'll merge this once I've completed some other stuff and have a chance to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usleep was deprecated with POSIX 2008 and optionally unavailable with
uClibc-ng.