Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single-element maps for functions instead of using dict_keys #1341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kannibalox
Copy link
Contributor

@kannibalox kannibalox commented Dec 16, 2024

@rakshasa
Copy link
Owner

rakshasa commented Dec 22, 2024

I don't like the use of a single-item map here, it is too easy to use wrongly and the dict type is a special type for method+args and ordered key+value lists.

Instead this should be a new class in libtorrent that holds a pointer to a string+vector pair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants