add query validator to ppl submit

Signed-off-by: Shenoy Pratik <[email protected]>
raintygao · Aug 17, 2023 · d102a97 · d102a97
1 parent 3217c6d
commit d102a97
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/public/components/llm_chat/components/feedback_modal.tsx b/public/components/llm_chat/components/feedback_modal.tsx
@@ -20,6 +20,7 @@ import React, { useState } from 'react';
 import { HttpStart } from '../../../../../../src/core/public';
 import { LANGCHAIN_API } from '../../../../common/constants/llm';
 import { coreRefs } from '../../../framework/core_refs';
+import { getPPLService } from '../../../../common/utils';
 
 export interface FeedbackFormData {
   input: string;
@@ -104,7 +105,11 @@ export const FeedbackModalContent: React.FC<FeedbackModalContentProps> = (props)
   const onSubmit = async (event: React.FormEvent) => {
     event.preventDefault();
     const errors = {
-      input: validator.input(props.formData.input),
+      input:
+        validator.input(props.formData.input) +
+        (props.metadata.type === 'ppl_submit'
+          ? await validator.validateQuery(props.formData.input)
+          : ''),
       output: validator.output(props.formData.output),
       correct: validator.correct(props.formData.correct),
       expectedOutput: validator.expectedOutput(
@@ -161,7 +166,6 @@ export const FeedbackModalContent: React.FC<FeedbackModalContentProps> = (props)
                 setFormErrors({ ...formErrors, input: validator.input(e.target.value) });
               }}
               isInvalid={hasError('input')}
-              disabled={props.metadata.type === 'ppl_submit'}
             />
           </EuiFormRow>
           <EuiFormRow
@@ -271,11 +275,27 @@ const useSubmitFeedback = (data: FeedbackFormData, metadata: FeedbackMetaData, h
   };
 };
 
+const validatePPLQuery = async (logsQuery: string) => {
+  let responseMessage = '';
+  const pplService = getPPLService();
+  await pplService
+    .fetch({ query: logsQuery, format: 'jdbc' })
+    .then((res) => {
+      if (res === undefined) responseMessage = ' Invalid PPL Query, please re-check the ppl syntax';
+    })
+    .catch((error: Error) => {
+      responseMessage = ' Invalid PPL Query, please re-check the ppl syntax';
+    });
+
+  return responseMessage;
+};
+
 const validator = {
   input: (text: string) => (text.trim().length === 0 ? ['Input is required'] : []),
   output: (text: string) => (text.trim().length === 0 ? ['Output is required'] : []),
   correct: (correct: boolean | undefined) =>
     correct === undefined ? ['Correctness is required'] : [],
   expectedOutput: (text: string, required: boolean) =>
     required && text.trim().length === 0 ? ['expectedOutput is required'] : [],
+  validateQuery: async (logsQuery: string) => await validatePPLQuery(logsQuery),
 };