ActiveSupport::Deprecation singleton was deprecated in 7.1, not 7.2 #407
Conversation
| @@ -47,7 +50,7 @@ module ActiveResource | |||
| autoload :Validations | |||
| autoload :Collection | |||
|
|
|||
| if ActiveSupport::VERSION::STRING >= "7.2" | |||
| if ActiveSupport::VERSION::STRING >= "7.1" | |||
There was a problem hiding this comment.
This is the actual bug fix.
.github/workflows/ci.yml
Outdated
| - ruby: "3.1" | ||
| env: | ||
| BRANCH: main | ||
| experimental: true |
There was a problem hiding this comment.
Rails main doesn't support Ruby 3.1 anymore.
brandoncc
force-pushed
the
brandoncc/fix-active-support-deprecation-version-condition
branch
3 times, most recently
from
006fdeb
to
2ef69c6
Compare
test/abstract_unit.rb
Outdated
| # Only necessary as long as Ruby 2.6 compatibility is maintained | ||
| require "ruby2_keywords" |
There was a problem hiding this comment.
Should this be wrapped in a condition for Ruby < 2.7? It seems to be a no-op in Ruby 3, but I don't know if there is a performance impact to be concerned about:
irb(main):001> require "ruby2_keywords"
=> false
There was a problem hiding this comment.
I'm also concerned about making keywords available in tests but not in the whole gem. Is that an okay approach? Should 2.6 support be dropped, or should the require be gem-wide?
There was a problem hiding this comment.
Why do you need this? I don't see any call to ruby2_keywords, and even if there was, it's simpler to do ruby2_keywords :foo if respond_to?(:ruby2_keywords, true) than to pull that dependency.
There was a problem hiding this comment.
Its coming from Drb: https://github.com/rails/activeresource/actions/runs/11599022232/job/32296232186
There was a problem hiding this comment.
I see, only a problem on 6-0-stable that has been EOL forever, we should drop Rails < 7.
byroot
force-pushed
the
brandoncc/fix-active-support-deprecation-version-condition
branch
from
2ef69c6
to
b1a0258
Compare
byroot
force-pushed
the
brandoncc/fix-active-support-deprecation-version-condition
branch
from
b1a0258
to
299d302
Compare
brandoncc
deleted the
brandoncc/fix-active-support-deprecation-version-condition
branch
ActiveResource 6.1.2 included a custom deprecator which uses an instance of
ActiveSupport::Deprecationrather than the singleton in Rails >= 7.2. That is because of this deprecation in ActiveSupport.The deprecation was actually shipped in Rails 7.1.0.beta1, so the condition should be on Rails >= 7.1.
The incorrect condition is causing CI for updates including ActiveResource >= 6.1.2 to fail with:
There are also two commits which fix CI.