Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor #5

wants to merge 8 commits into from

Conversation

allanon
Copy link
Contributor

@allanon allanon commented May 21, 2015

New Features

  • Move the definitions of "please", "plz", and "more" into the config.
  • Add new commands:
    • "help buffplease" - show help for the new buffplease command
    • "buffplease list" - list the buff queue
    • "buffplease validate" - validate configuration
  • Try to make sure that buffs round-robin amongst requesting characters if there is more than one, to prevent any one person from monopolizing the buffs.
  • Listen for skill_use_location (so we know when, for example, Sanctuary finishes casting).

Refactor:

  • Drop redundant parseActor and parseInfo methods (because Kore does this automatically anyway).
  • Use a single queue instead of a per-requestor queue.
  • Treat $buff as if it were read-only, to allow it to be treated like configuration, and to allow reloads of the plugin to overwrite it without also wiping out the buff queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant