Skip to content

Commit

Permalink
Merge pull request #708 from rage/fix
Browse files Browse the repository at this point in the history
Fix error when changing TMC data path on Windows
  • Loading branch information
nygrenh authored Jan 25, 2024
2 parents 8555386 + 776e2aa commit 89cd099
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,18 @@ Update the `tmc-python-tester` submodule
git submodule init && git submodule update
```

Repeat the same for the testing backend:
Then prepare the backend:

```bash
cd backend && npm ci && npm run setup
```

As well as the webview:

```bash
cd webview && npm ci
```

You will need to rerun the setup when langs is updated, as this step will download the appropriate version of the CLI for the integration tests.

## Formatting
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/commands/changeTmcDataPath.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ export async function changeTmcDataPath(actionContext: ActionContext): Promise<v
canSelectFolders: true,
canSelectMany: false,
openLabel: "Select folder",
defaultUri: vscode.Uri.parse(old),
defaultUri: vscode.Uri.file(old),
};

const newPath = (await vscode.window.showOpenDialog(options))?.[0];
if (newPath && old) {
const res = await dialog.progressNotification(
Expand Down

0 comments on commit 89cd099

Please sign in to comment.