Mailchimp syncer checks if user has completed course

[Maijjay]

Summary by CodeRabbit

• Bug Fixes
  • Enhanced query logic for syncing user marketing consents with additional timestamp comparison.
  • Improved criteria for fetching unsynced user marketing consents related to course module completions.

[coderabbitai]

Walkthrough

The pull request modifies a SQL query in the headless LMS service to enhance the logic for fetching unsynced user marketing consents. The change adds an additional condition to check the updated_at timestamp of course module completions against the synced_to_mailchimp_at timestamp. This modification expands the criteria for selecting records that need to be synchronized, potentially capturing more scenarios where marketing consent data requires updating.

Changes

File	Change Summary
services/headless-lms/models/.sqlx/query-*.json	Updated query hash and added new condition cmc.updated_at > umc.synced_to_mailchimp_at
services/headless-lms/models/src/marketing_consents.rs	Modified fetch_all_unsynced_user_marketing_consents_by_course_language_group_id function to include new query condition

Possibly related PRs

• Pass either an empty string or timestamp to mailchimp graduated field #1358: Similar modifications to SQL query conditions involving updated_at timestamp checks in marketing consent synchronization

Poem

🐰 A rabbit's query, now more bright,
Syncing consents with newfound might
One timestamp joins the dancing line
Marketing magic starts to shine
Hop, hop, data flows just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

services/headless-lms/models/src/marketing_consents.rs (1)

Line range hint 119-119: Update function documentation to mention course completion tracking.

The function's documentation should be updated to mention that it also tracks course completion updates.

-/// Fetches all user marketing consents with detailed user information for a specific course language group, if they haven't been synced to Mailchimp or if there have been updates since the last sync.
+/// Fetches all user marketing consents with detailed user information for a specific course language group, if they haven't been synced to Mailchimp or if there have been updates (including course completions) since the last sync.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdbf920 and 4db5668.

📒 Files selected for processing (2)

• services/headless-lms/models/.sqlx/query-9085a18a90d505c905af9b0bbd078bf3b88a6ea28f869d5a106b6456752361f0.json (2 hunks)
• services/headless-lms/models/src/marketing_consents.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: headless_lms
• GitHub Check: build
• GitHub Check: build-and-deploy

🔇 Additional comments (4)

services/headless-lms/models/.sqlx/query-9085a18a90d505c905af9b0bbd078bf3b88a6ea28f869d5a106b6456752361f0.json (2)

3-3: LGTM! Query enhancement properly tracks course completion updates.

The added condition cmc.updated_at > umc.synced_to_mailchimp_at correctly ensures that Mailchimp is updated when a user completes a course after their last sync.

---

121-121: LGTM! Query hash updated correctly.

The hash value has been properly updated to reflect the query changes.

services/headless-lms/models/src/marketing_consents.rs (2)

161-161: LGTM! Condition added to sync course completion updates.

The added condition OR cmc.updated_at > umc.synced_to_mailchimp_at properly ensures that marketing consents are resynced when course completion status changes.

---

Line range hint 119-164: Verify Mailchimp API rate limits.

The addition of course completion as a sync trigger might increase the frequency of Mailchimp API calls. Please ensure this aligns with your Mailchimp API rate limits and consider implementing rate limiting if necessary.