Peer review accepting threshold is disabled if accepting strategy is …

…manual review everything (#1206) * Peer review accepting threshold is disabled if accepting strategy is manual review everything * test fix --------- Co-authored-by: Maija Y <[email protected]>
rage · Nov 28, 2023 · 7f50594 · 7f50594
1 parent e50a992
commit 7f50594
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/services/cms/src/components/PeerReviewEditor.tsx b/services/cms/src/components/PeerReviewEditor.tsx
@@ -399,6 +399,10 @@ const PeerReviewEditor: React.FC<PeerReviewEditorProps> = ({
                   step="0.01"
                   min={0}
                   required
+                  disabled={
+                    parsedPeerReviewConfig.accepting_strategy.toString() ===
+                    "ManualReviewEverything"
+                  }
                   value={parsedPeerReviewConfig.accepting_threshold}
                   onChangeByValue={(value) => {
                     handlePeerReviewValueChange(value, "accepting_threshold")

diff --git a/system-tests/src/tests/peer-reviews/peer-review-editor.spec.ts b/system-tests/src/tests/peer-reviews/peer-review-editor.spec.ts
@@ -84,10 +84,6 @@ test("default peer review editing", async ({ page, headless }, testInfo) => {
     )
     .selectOption("ManualReviewEverything")
 
-  await page1.locator('input[type="number"]').nth(2).click()
-  // Fill input[type="number"] >> nth=2
-  await page1.locator('input[type="number"]').nth(2).fill("2.5")
-
   await page1.getByRole("button", { name: "Delete" }).nth(1).click()
   // Fill text=General comments
   await page1.locator("text=General comments").fill("test")