add support for custom select indicator #667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No plans to add this level of customization at this point. I recommend building a custom version of the select using the underlying Radix Primitives if you want to deviate from the options currently provided. |
I can definitely understand that, but there's a lot of functionality I'd have to build back in that is currently implemented using internal APIs :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to provide a custom indicator to the
Selectcomponent, replacing the default checkmark. This is useful in situations where you're using a custom icon set.Testing steps
Provide an
indicatorprop toSelect.Root. This should be aReactNode. An example is given insink.tsx.