[DropdownMenu] Fix touch devices trigger bug #3241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasongerbes
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where
DropdownMenuTriggerwould open inadvertently on touch-based scroll (#1912).The previous PR for this fix (#2616) was rejected as it broke a feature where the user can select an item in one click (pointer down on trigger, move, pointer up on item). This PR retains that behaviour.
See the related PR (#2939) for the Select component.
Touch before:
before.mov
Touch after:
after.mov
Pointer down behaviour for mouse devices has been preserved:
Screen.Recording.2024-11-21.at.11.13.27.PM.mov
Note: I was unable to replicate #1658 (also addressed in #2939) with the Dropdown Menu component, so I haven't copied the changes that were made to
SelectItemover toDropdownMenuItem. Happy to do so if you'd like me to.