Fix Presence component memory leak #3234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presence component doesn't unmount itself, and by keeping a reference around for node's styles after the node has unmounted, the node itself cannot ever get garbage collected. This affects pretty much all radix primitive components.
lauri865
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3202
Took a while to track this down, but here goes:
When the child of Presence component gets unmounted,
stylesRefis not clean up, which in turn prevents the detached nodes from being garbage collected, as it's holding a reference to the node. Affects any radix component that depends on Presence.Note when testing: please build React for production first, as the dev-mode itself can have memory leaks.
Alternative could be to use WeakRef, but I wasn't sure how the Radix team feels about its browser support.