Add forward ref to react/select:Select #2591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roanmh
force-pushed
the
select-forward-ref
branch
from
dd12d56 to
8f6f457
Compare
|
Hello @benoitgrelard, @andy-hook any updates here? |
|
I think we need to fix this in other components that do this as well, but I'm not sure this is exactly the solution we want. I need to think through this a bit more to land on a more wholistic solution. Not sure we'll keep the bubble elements in the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2590 (More detail in issue description)
Selectcomponent needs to forward a ref toBubbleSelectto be compatible withreact-hook-form'sregister()function.