fix: fix router plugin #550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfencik
force-pushed
the
fix_router_plugin
branch
from
b9a771e to
97cec43
Compare
mfencik
force-pushed
the
fix_router_plugin
branch
from
97cec43 to
6e37fa2
Compare
|
looks like @skrobul beat me to it - https://github.com/rackerlabs/understack/pull/549/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core port_forwarding plugin is hard coded to use the default "router" plugin so we can't use it with our UnderStackL3ServicePlugin. ATM we don't use the port_forwarding so we're removing it for now, if needed in the future, we can create our own by just subclassing the core port_forwarding plugin and point it to use our UnderStackL3ServicePlugin