feat: update Ironic for jobs and ArgoCD application deployment #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using the helm repo directly for Ironic and use a multi-source application in ArgoCD to allow the user to more easily override settings.
Jobs cannot be run as pre-install or pre-upgrade because ArgoCD tries to run them before dependent resources have been created. They cannot be post-install or post-upgrade because ArgoCD will only run them once services are healthy. But the services depend on the jobs to run to be healthy. So have them run in the same phase as the deployment.
skrobul
approved these changes
Apr 16, 2024
andrrax
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Ironic to use the job annotation to not leave it in a bad state with ArgoCD. Updated how the ArgoCD application is created and deployed to match how Keystone is configured and allow easier overriding.