Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync_interfaces: make the port names unique #343

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

skrobul
Copy link
Collaborator

@skrobul skrobul commented Sep 25, 2024

Ironic's database schema requires the baremetal port names to be unique so we prepend the Node ID.

@skrobul skrobul requested a review from a team September 25, 2024 08:58
@skrobul skrobul changed the title sync_interfaces: make the port names unique fix: sync_interfaces: make the port names unique Sep 25, 2024
Copy link

github-actions bot commented Sep 25, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
178 85 48% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 1160ab6 by action🐍

Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was unfortunate. Good solution.

@cardoe cardoe merged commit b699e4e into main Sep 25, 2024
21 of 22 checks passed
@cardoe cardoe deleted the set-unique-names-on-baremetal-ports branch September 25, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants