-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Workflow to synchronize Nautobot Device to Ironic Node #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the custom token for the registry.
skrobul
force-pushed
the
workflow-create-node
branch
10 times, most recently
from
April 3, 2024 12:36
e3a734a
to
920bb46
Compare
skrobul
force-pushed
the
workflow-create-node
branch
2 times, most recently
from
April 3, 2024 13:58
b163ae2
to
27388cc
Compare
mfencik
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change needed, otherwise looking good
skrobul
force-pushed
the
workflow-create-node
branch
from
April 4, 2024 11:23
20115d8
to
da39ad3
Compare
This is mostly just to document how the typical feature folder structure should look like.
This image provides preinstalled python-ironic client.
Instead of waiting for an explicit button press, we setup Nautobot to send webhooks to Argo Events any time the Interface is changed. When particular conditions are met (device is a server, has the DRAC IP and the Interface is named 'iLO'), we trigger the workflow to synchronize information to Ironic.
This is to avoid accidentally overwriting the credentials and other redfish driver settings which this workflow does not have awareness of.
skrobul
force-pushed
the
workflow-create-node
branch
from
April 8, 2024 15:30
da39ad3
to
c0bcd72
Compare
cardoe
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings an Argo Workflow and sensor that reacts to an 'Interface Updated' event produced by Nautobot's Event Source. Once activated, it updates (or creates) the Node representation in Ironic.
Closes PUC-212