feat: development shells with Devbox #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrobul
changed the title
skrobul
force-pushed
the
devbox-and-poetry
branch
from
922ecb7 to
e3e20f1
Compare
skrobul
changed the title
skrobul
force-pushed
the
devbox-and-poetry
branch
from
e3e20f1 to
6c203ea
Compare
This commit adds [Devbox](https://www.jetify.com/devbox/) integration that greatly simplifies setting up the local development environment and allows to make it consistent. It can even be used in Github's CI. Three separate environments were created with (hopefully) appropriate tools inside them: - ironic_understack - neutron_understack - understack-workflows In future, we may consider consolidating all of these, but I was not sure if there won't be any conflicts so kept them separately for now.
This reverts commits 664312d8e1828e5608671b0b2853f8c62ba0e165 and a7819cf These changes have already been implemented in: #251 #253 Both of the PRs solve the same problem, so I don't need to solve it here again. It was initially fixed only because I was not aware of the other PRs. Reverting instead of dropping these commits, because they have been referenced externally in the comments.
skrobul
force-pushed
the
devbox-and-poetry
branch
from
6c203ea to
019efd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
convertsneutron_understackto use Poetry instead of setuptoolsadds Devbox integration greatly simplifies setting up the local development environment and makes it consistent. It can even be used in Github's CI.
Three separate environments were created with (hopefully) appropriate tools inside them:
ironic_understackneutron_understackunderstack-workflowsIn future, we may consider consolidating all of these, but I was not sure if there won't be any conflicts so kept them separately for now.
fixesneutron_understacktests