fix: sync interfaces errors #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes e5e268c where the wrong parameter was put into the workflow.
The function converted the parameters incorrectly and didn't need the helper since we used a dataclass. Added a test to catch this case in the future.
cardoe
force-pushed
the
fix-wf-param
branch
2 times, most recently
from
3bb6010 to
5fbcf93
Compare
skrobul
force-pushed
the
fix-wf-param
branch
3 times, most recently
from
301a796 to
2980a92
Compare
For testing allow us to build the containers. Allow workflow_dispatch to rebuild the containers. Always push the container when running a PR.
ctria
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes e5e268c where the wrong parameter was put into the workflow. Fixed the add node code and added tests for it.