-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: argo-workflows and argo-events deployments (JIRA:PUC-193) #20
Conversation
a27d7e9
to
c5fd6ff
Compare
So just playing with workflows some I think these RBACs are big and maybe not correct? Look at this role from the docs https://github.com/argoproj/argo-workflows/blob/main/manifests/quick-start/base/webhooks/submit-workflow-template-role.yaml which should be enough for an event to trigger a workflow. They use it in the example docs. As far as auth goes, if we're wanting to expose the workflow view we should follow https://argo-workflows.readthedocs.io/en/latest/argo-server-sso/ and create accounts in keystone which dex will serve up. |
I agree, I'll revisit the RBAC roles. That said, some of the RBAC role permissions were set to provide the argo-workflows UI access to view/create Workflows and WorkflowTemplates. Additionally, because argo-workflows is configured in a namespaced scope, ClusterRoles were used to provide permissions to the clusterworkflowtemplates cluster resource to the argo-server service account within the argo namespace. I think we'll likely want to make a decision on the workflow UI and if we want to run argo-workflows in namespaced or cluster scope so we can be precise with the RBAC perms. |
9258230
to
4cf0eaf
Compare
4cf0eaf
to
25d7d56
Compare
25d7d56
to
9d3c2ba
Compare
I have review the RBAC configuration, and updated the RBAC roles with additional context. Ultimately I feel this configuration is sound and necessary when running both argo-workflows/events in a managed namespace setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since dex will be implemented in another PR, i'm approving this so we can move forward
This creates basic argo-workflow and argo-events deployments