fix: stop using device name for interface sync

[cardoe]

Use the device ID / UUID which is a better identifier for us to use to find the device to sync the interfaces for. This saves us a trip to the Nautobot DB as well. In Nautobot the device name does not have to be unique so this avoids possible issues there. Added tests of the parser to make sure we get the correct data. Added types so we can have better tests in the future. Cleaned up the duplicate hostname usage in the workflow as well.

[skrobul]

why are we changing the terminology here (oob vs bmc)? It felt more consistent with oob everywhere

[cardoe]

ah I didn't see your comment before I hit merge. I'm trying to follow the terminology used in industry which is BMC

[skrobul]

No worries - In my eyes BMC is just an "implementation" of OOB, or more specifically a name of hardware used to provide OOB services.

I don't mind using either, but let's keep it consistent, for example instead of this:

def do_sync(device_id: UUID, nb_url: str, nb_token: str, bmc_user: str, bmc_pass: str):
    nautobot = Nautobot(nb_url, nb_token, logger=logger)
    oob_ip = nautobot.device_oob_ip(device_id)
    oob = oob_sushy_session(oob_ip, bmc_user, bmc_pass)

do this:

def do_sync(device_id: UUID, nb_url: str, nb_token: str, bmc_user: str, bmc_pass: str):
    nautobot = Nautobot(nb_url, nb_token, logger=logger)
    bmc_ip = nautobot.device_bmc_ip(device_id)
    bmc = bmc_sushy_session(bmc_ip, bmc_user, bmc_pass)

</ocd>