Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep fixing these containers #193

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: keep fixing these containers #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd33777
fix: remove bad import and let the error bubble
cardoe Aug 2, 2024
b202a46
chore: re-build the containers when python code updates
cardoe Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/containers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ on:
paths:
- "containers/**"
- ".github/workflows/containers.yaml"
- "python/**"
pull_request:
paths:
- "containers/**"
- ".github/workflows/containers.yaml"
- "python/**"
workflow_dispatch:

jobs:
Expand Down
8 changes: 1 addition & 7 deletions python/understack-workflows/understack_workflows/main/sync_nautobot_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import sushy

from understack_workflows.helpers import arg_parser
from understack_workflows.helpers import credential
from understack_workflows.helpers import exit_with_error
from understack_workflows.helpers import is_off_board
from understack_workflows.helpers import oob_sushy_session
from understack_workflows.helpers import setup_logger
Expand All @@ -27,10 +24,7 @@ def main():
oob_ip = nautobot.device_oob_ip(device_name)
oob = oob_sushy_session(oob_ip, oob_username, oob_password)

try:
chassis = Chassis.from_redfish(oob)
except sushy.exceptions.AccessError as e:
exit_with_error(e)
chassis = Chassis.from_redfish(oob)

interfaces = [
interface for interface in chassis.network_interfaces if is_off_board(interface)
Expand Down
Loading