Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check argo workflows and workflow templates in pre-commit #115

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Jun 5, 2024

Utilize pre-commit to validate the argo workflows and argo workflow templates against the published JSON schema.

@skrobul
Copy link
Collaborator

skrobul commented Jun 5, 2024

I like that, let's do it.

btw, they also publish json schemas at various locations that can be used to verify more than just a WorkflowTemplates.

@cardoe
Copy link
Contributor Author

cardoe commented Jun 5, 2024

That's a better solution.

Utilize pre-commit to validate the argo workflows and argo workflow
templates against the published JSON schema.
@cardoe cardoe force-pushed the check-workflows branch from f83746d to 5024ae0 Compare June 18, 2024 20:40
@cardoe cardoe changed the title ci: use argo template lint to validate workflows ci: check argo workflows and workflow templates in pre-commit Jun 18, 2024
@cardoe cardoe marked this pull request as ready for review June 18, 2024 20:41
@cardoe
Copy link
Contributor Author

cardoe commented Jun 18, 2024

At least this adds a pre-commit rule to start.

@cardoe cardoe merged commit 127b46d into main Jun 18, 2024
9 checks passed
@cardoe cardoe deleted the check-workflows branch June 18, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants