Skip to content

Commit

Permalink
openstack: adjust default PDB minAvailable
Browse files Browse the repository at this point in the history
With current default setup we only spinup a single replica for each of
the components, then we apply PDB that requires this single replica to
always be available which renders the nodes the components are running
on unmaintainable.

This commit lowers the number of required available replicas to 0 with
the intention that users will override this with a more appropriate
values when scaling up the number of replicas in the deploy
configuration.
  • Loading branch information
skrobul committed Dec 2, 2024
1 parent 3aaad5b commit 37bbdd6
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 6 deletions.
4 changes: 3 additions & 1 deletion components/glance/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ pod:
lifecycle:
disruption_budget:
api:
min_available: 1
# this should be set to no more than (pod.replicas.api - 1)
# usually set on per-deployment basis.
min_available: 0
resources:
enabled: true
probes:
Expand Down
8 changes: 8 additions & 0 deletions components/horizon/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ manifests:
secret_db: false
service_ingress: false

pod:
lifecycle:
disruption_budget:
horizon:
# this should be set to no more than (pod.replicas.horizon - 1)
# usually set on per-deployment basis.
min_available: 0

# We don't want to enable OpenStack Helm's
# helm.sh/hooks because they set them as
# post-install,post-upgrade which in ArgoCD
Expand Down
4 changes: 3 additions & 1 deletion components/ironic/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ pod:
lifecycle:
disruption_budget:
api:
min_available: 1
# this should be set to no more than (pod.replicas.api - 1)
# usually set on per-deployment basis.
min_available: 0

# we don't want to enable OpenStack Helm's
# helm.sh/hooks because they set them as
Expand Down
4 changes: 3 additions & 1 deletion components/keystone/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,9 @@ pod:
lifecycle:
disruption_budget:
api:
min_available: 1
# this should be set to no more than (pod.replicas.api - 1)
# usually set on per-deployment basis.
min_available: 0

conf:
keystone:
Expand Down
4 changes: 3 additions & 1 deletion components/neutron/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ pod:
lifecycle:
disruption_budget:
server:
min_available: 1
# this should be set to no more than (pod.replicas.server - 1)
# usually set on per-deployment basis.
min_available: 0
mounts:
neutron_server:
neutron_server:
Expand Down
4 changes: 3 additions & 1 deletion components/nova/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ pod:
lifecycle:
disruption_budget:
osapi:
min_available: 1
# this should be set to no more than (pod.replicas.osapi - 1)
# usually set on per-deployment basis.
min_available: 0

manifests:
job_db_init: false
Expand Down
4 changes: 3 additions & 1 deletion components/placement/aio-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ pod:
lifecycle:
disruption_budget:
api:
min_available: 1
# this should be set to no more than (pod.replicas.api - 1)
# usually set on per-deployment basis.
min_available: 0

manifests:
job_db_init: false
Expand Down

0 comments on commit 37bbdd6

Please sign in to comment.