Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert prometheus charts to helm install #597

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

awfabian-rs
Copy link
Contributor

No description provided.

Copy link
Contributor

@mnaghavi mnaghavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the suggested change, the rest LGTM

Copy link
Contributor

@dkeirns dkeirns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on Mohammad's review

@awfabian-rs awfabian-rs merged commit c2714f0 into rackerlabs:main Nov 27, 2024
8 checks passed
mnaghavi pushed a commit to mnaghavi/genestack that referenced this pull request Dec 9, 2024
* fix: prometheus-blackbox-exporter kustomize->helm driven install
* fix: prometheus-postgres-exporter kustomize->helm driven install
* fix: prometheus-rabbitmq-exporter kustomize->helm driven install
* fix: prometheus-pushgateway kustomize->helm driven install
* fix: prometheus-mysql-exporter kustomize->helm driven install

JIRA:OSPC-854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants