-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert prometheus charts to helm install #597
Merged
awfabian-rs
merged 11 commits into
rackerlabs:main
from
awfabian-rs:OSPC-854-prometheus-charts
Nov 27, 2024
Merged
fix: convert prometheus charts to helm install #597
awfabian-rs
merged 11 commits into
rackerlabs:main
from
awfabian-rs:OSPC-854-prometheus-charts
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnull
approved these changes
Nov 27, 2024
mnaghavi
reviewed
Nov 27, 2024
mnaghavi
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the suggested change, the rest LGTM
Co-authored-by: Mohammad Naghavi <[email protected]>
dkeirns
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on Mohammad's review
mnaghavi
pushed a commit
to mnaghavi/genestack
that referenced
this pull request
Dec 9, 2024
* fix: prometheus-blackbox-exporter kustomize->helm driven install * fix: prometheus-postgres-exporter kustomize->helm driven install * fix: prometheus-rabbitmq-exporter kustomize->helm driven install * fix: prometheus-pushgateway kustomize->helm driven install * fix: prometheus-mysql-exporter kustomize->helm driven install JIRA:OSPC-854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.