Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adds security primer for genestack development #578

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

sulochan
Copy link
Collaborator

Adds a generic security primer that follows guidelines from CNCF to drive the development of genestack. Also tries to intersect it with openstack infra to highlight what security measures can be done at each layer of the cloud.

JIRA: OSPC-670

@sulochan sulochan marked this pull request as draft November 20, 2024 15:50
@sulochan sulochan requested a review from BjoernT November 20, 2024 15:51
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs trailing whitespace fixed

@sulochan sulochan force-pushed the security-primer branch 3 times, most recently from 7f5a018 to f2e0dfb Compare December 2, 2024 10:33
@sulochan sulochan marked this pull request as ready for review December 2, 2024 10:33
@sulochan sulochan force-pushed the security-primer branch 2 times, most recently from e70d039 to d9e3453 Compare December 2, 2024 10:44
Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits on the heading structure, but otherwise, this looks great.

docs/security-introduction.md Outdated Show resolved Hide resolved
docs/security-lifecycle.md Outdated Show resolved Hide resolved
docs/security-lifecycle.md Outdated Show resolved Hide resolved
docs/security-lifecycle.md Outdated Show resolved Hide resolved
docs/security-lifecycle.md Outdated Show resolved Hide resolved
docs/security-stages.md Outdated Show resolved Hide resolved
docs/security-lifecycle.md Show resolved Hide resolved
docs/security-lifecycle.md Show resolved Hide resolved
docs/security-lifecycle.md Show resolved Hide resolved
docs/security-stages.md Show resolved Hide resolved
@sulochan sulochan force-pushed the security-primer branch 3 times, most recently from 35bde77 to b0b40a1 Compare December 2, 2024 17:04
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDLC potion does not align with what we've implemetned for Rackspace. And one type.

docs/security-introduction.md Outdated Show resolved Hide resolved
docs/security-introduction.md Outdated Show resolved Hide resolved
Adds a generic security primer that follows guidelines from
CNCF to drive the development of genestack. Also tries to
intersect it with openstack infra to highlight what security
measures can be done at each layer of the cloud.

JIRA: OSPC-670
Copy link
Contributor

@rackerchris rackerchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@rackerchris rackerchris merged commit a631fc7 into rackerlabs:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants