-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dk ospc 721 #571
Closed
Closed
Dk ospc 721 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add generic Windows image upload instructions.
dkeirns
requested review from
japerezjr and
sowm9802
and removed request for
japerezjr
November 18, 2024 19:07
@dkeirns some end-of-file and whitespace issues. You can install the pre-commit to check and clean these up for you. Also, I think these commits will need to be signed, it might complain about that after the precommit stuff is resolved. |
found and removed extra CRLF, added end of file CRLF |
Attempting to sign the code
human readable URL markdown syntax as recommended by Sowmya
hopefully, fixed the markdown for the URL. |
sowm9802
approved these changes
Nov 19, 2024
cloudnull
approved these changes
Nov 19, 2024
sowm9802
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a section on uploading a Windows image to Glance enabling customers to create and upload their own Volume License images.