-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch OVN backups to using Swift. #273
Conversation
JIRA:OSPC-432
The OVN pod doesn't have Python or a lot of tools. Perl looked like the best thing available for parsing the JSON to get the object-store URL out of the service catalog. This switches to using Ceph's Swift API to using keystone and Swift. I tried this out on my test cluster. |
9b248fc
to
056e6eb
Compare
This helps make it easy to use: commonLabels: app: ovn-backup to label all of the resources in kustomization.yaml, and the backup functionality started cluttering up the main directory. JIRA:OSPC-432
Please review and merge or request changes. The OVN backup stuff started looking a little cluttered, so I put it in a subdirectory. That also helped me use:
to label the resources, which let me do something like:
to apply changes without collecting old generated Secrets and ConfigMaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq - instead of using a set of scripts can we use the openstack client to upload the our backups?
@cloudnull I mostly did it this way to avoid installing dependencies. From container images generally available, I could get one with the OpenStack command, or one with kubectl-ko to actually do the OVN backup, but not both. So I would need to download and install one or the other, which would put an additional point of failure in the backup process. So, I see three options:
3 seems like the cleanest and most logical option, but I don't think we have any really custom-built container images and a location for them set up yet. Let me know how you think we should proceed here. We might already have a place for our own container images I don't know about yet! |
aedan, maybe the2hill, showed me this in the standup: https://github.com/rackerlabs/genestack/tree/main/Containerfiles I think the entire process of getting an image there seems a bit involved for this. Another option seems like running the OpenStack client in a separate container in the pod, and passing it through the /backup file system. Also, I think we will ultimately end up wanting to use Swift tempauth for things like this, which I think might end up eliminating a lot of the need for the machinery of parsing a service catalog, since I think it just does authentication, gives you a token, and it doesn't give you a service catalog anyway. |
closing in favor of #304 |
JIRA:OSPC-432