Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable resource limits on pods #262

Closed
wants to merge 1 commit into from

Conversation

sulochan
Copy link
Collaborator

We have been running without setting resource limits, which can cause all sorts of problem. This patch simply enabled the default resource limits set by the charts.

There might be need for further tuning of limits.

We have been running without setting resource limits, which
can cause all sorts of problem. This patch simply enabled
the default resource limits set by the charts.

There might be need for further tuning of limits.
@sulochan sulochan requested a review from cloudnull May 13, 2024 12:33
@BjoernT
Copy link
Collaborator

BjoernT commented May 13, 2024

I prefer not to enable resource limits initially and gather the utilization once we are in a LA phase and set these limit.
The default limits are way too small, unusable, for larger production setups from what I can see and it would lead to constant pod terminations

@sulochan
Copy link
Collaborator Author

I prefer not to enable resource limits initially and gather the utilization once we are in a LA phase and set these limit. The default limits are way too small, unusable, for larger production setups from what I can see and it would lead to constant pod terminations

Fair enough. I agree with you that the values can be better tweaked. Lets wait for GA to get some data.

@sulochan
Copy link
Collaborator Author

sulochan commented Jul 2, 2024

Closing this for now. Will re-visit after LA with better understanding of usage.

@sulochan sulochan closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants