Add optional kustomize letsencrypt overlay #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnull
reviewed
Apr 22, 2024
cloudnull
suggested changes
Apr 22, 2024
When using letsencrypt, you must annotate the named ingress with the letsencrypt cluster-issuer as well as any other desired acme.cert-manager.io annotations [1]. As most services have multiple ingresses (external vs internal), we must only annotate the ingress that will be accessed externally, else the ACME solver will not work correctly. Using this optional overlay will help ensure the expected ingress is annotated. So that the challenge url is accessible externally. 1. https://cert-manager.io/docs/usage/ingress/#supported-annotations
The original key paths were incorrect. Not all services use `api` here.
Expand the prod overrides example to include the necessary issuerRef name of letsencrypt-prod, it is a better fit. Remove the fake cert, key, and anchors to them.
LukeRepko
force-pushed
the
letsencrypt
branch
2 times, most recently
from
14801a5 to
742f483
Compare
cloudnull
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using letsencrypt, you must annotate the named ingress with the letsencrypt cluster-issuer as well as any other desired acme.cert-manager.io annotations [1]. As most services have multiple ingresses (external vs internal), we must only annotate the ingress that will be accessed externally, else the ACME solver will not work correctly.
Using this optional overlay will help ensure the expected ingress is annotated. So that the challenge url is accessible externally.