Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uploading OVN backups to Ceph Swift API gateway #173

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

awfabian-rs
Copy link
Contributor

JIRA:OSPC-341

@awfabian-rs awfabian-rs marked this pull request as draft March 21, 2024 22:36
@awfabian-rs
Copy link
Contributor Author

awfabian-rs commented Mar 21, 2024

Currently in draft status to:

  1. See how the CronJob runs on my test cluster when the cron job time happens.
    • which I will check tomorrow
    • but I do expect it to work, since I tried the pod template in the CronJob independently of a CronJob already
  2. Look at Use HashiCorp Vault for OSH deployment #151 as an example and see if we can use Vault here.

@awfabian-rs awfabian-rs changed the title Add uploading OVN backups to OSPCv1 Add uploading OVN backups to Ceph Swift API gateway Apr 15, 2024
@awfabian-rs
Copy link
Contributor Author

awfabian-rs commented Apr 15, 2024

  • I modified this to use a Ceph Swift API gateway because we do our SJC database MariaDB backups to that.
  • I tested this on the DFW environment.
  • I moved a few things out into separate files and used some kustomize generators
    • It seems easier to read ovn-backup.sh as a stand-alone file.
    • The ovn-backup-config patch almost completely duplicated the ConfigMap in the main file, and it just sets environment variables anyway, so I used a kustomize ConfigMap generator to just put the key-value pairs into a ConfigMap.
  • I have an intermediate WIP commit. You will probably want to 'squash merge' this.

Feel free to merge if it looks ready to you. Please review and let me know any change(s) needed.

@awfabian-rs awfabian-rs marked this pull request as ready for review April 15, 2024 23:34
@cloudnull cloudnull merged commit 8b58594 into rackerlabs:main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants