-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nova cpu allocation ratio.md #160
Nova cpu allocation ratio.md #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the 2 small spelling mistakes, lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected spellings
it's failing the one test. re: https://github.com/rackerlabs/genestack/actions/runs/8342441637/job/22835411053?pr=160#step:5:99 - there's some extra whitespace in the doc that needs to be cleaned up. If you run the pre-commit command it should fix simple issues like this automatically. This is the command from the test. pre-commit run --show-diff-on-failure --color=always --files docs/openstack-cpu-allocation-ratio.md helm-configs/nova/nova-helm-overrides.yaml mkdocs.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.
Guide to evaluate openstack nova cpu allocation ratio is updated as per "mkdocs" format and added to openstack section of operational guide in "mkdocs.yml". Default ratio has been updated to 8 from 3.
Jira Reference: https://rackspace.atlassian.net/browse/OSPC-68