Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova cpu allocation ratio.md #160

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

ajay2012
Copy link
Contributor

Guide to evaluate openstack nova cpu allocation ratio is updated as per "mkdocs" format and added to openstack section of operational guide in "mkdocs.yml". Default ratio has been updated to 8 from 3.

Jira Reference: https://rackspace.atlassian.net/browse/OSPC-68

Copy link
Collaborator

@sulochan sulochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 2 small spelling mistakes, lgtm.

docs/openstack-cpu-allocation-ratio.md Outdated Show resolved Hide resolved
@ajay2012 ajay2012 marked this pull request as draft March 19, 2024 11:45
@ajay2012 ajay2012 marked this pull request as ready for review March 19, 2024 11:51
Copy link
Contributor Author

@ajay2012 ajay2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected spellings

@ajay2012 ajay2012 requested a review from sulochan March 19, 2024 12:01
@cloudnull
Copy link
Contributor

it's failing the one test. re: https://github.com/rackerlabs/genestack/actions/runs/8342441637/job/22835411053?pr=160#step:5:99 - there's some extra whitespace in the doc that needs to be cleaned up.

If you run the pre-commit command it should fix simple issues like this automatically. This is the command from the test.

pre-commit run --show-diff-on-failure --color=always --files docs/openstack-cpu-allocation-ratio.md helm-configs/nova/nova-helm-overrides.yaml mkdocs.yml

Copy link
Contributor

@cloudnull cloudnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above.

@cloudnull cloudnull merged commit 2bf2f5a into rackerlabs:main Mar 19, 2024
4 of 5 checks passed
@ajay2012 ajay2012 deleted the nova_cpu_allocation_ratio.md branch March 28, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants