-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce ceilometer helm chart overrides #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This begins to add the overrides for the Ceilometer helm chart. Ceilometer provides metering, monitoring, and alarming capabilities in Openstack for billing, performance, optimization, and capacity planning purposes.
Trying to pull the wallaby image for ceilometer-api results in a 404 not found now. ceilometer-api is in the base image as of commit cd67930 per the upstream kolla repo, so pull that instead.
ceilometer collector was removed from ceilometer code base[1] [1] https://review.openstack.org/504244
LukeRepko
force-pushed
the
ceilometer
branch
4 times, most recently
from
March 19, 2024 00:03
31dc4a5
to
d2e87a5
Compare
LukeRepko
changed the title
[WIP] feat: introduce ceilometer helm chart overrides
feat: introduce ceilometer helm chart overrides
Mar 19, 2024
LukeRepko
requested review from
the2hill and
andrew-vant
and removed request for
andrew-vant
March 19, 2024 00:24
LukeRepko
force-pushed
the
ceilometer
branch
2 times, most recently
from
March 19, 2024 01:19
14d1231
to
51ae24a
Compare
This disables deployment of the api pod and removes related api configuration as ceilometer no longer has a rest API. It is simply a worker service at this point. Gnocchi API is preferred over ceilometer.
The database section is not used, but the base chart still tries to set some sane default values, so to avoid confusion, just override those to a string value that makes it obvious this section is not used. The recommended storage location for meters and events is Gnocchi, which is automatically discovered and used by means of keystone.
This was explicitly set to notify:// without any context as to what that is or does. The configuration does not list that as a valid value, so let's replace the publisher with the default, `gnocchi`.
There is no endpoint for ceilometer anymore so remove the related job that makes a service in keystone for one.
This was the newest tagged image that I could find for Ceilometer. We will need to investigate building our own Ceilometer images for a later release of Genstack.
The helm chart has a db_sync job which executes ceilometer-upgrade which executes the storage upgrade function that initiates the resource types in gnocchi with their attributes.
The event definitions defined in the helm chart were very dated, update them to match those found in the yoga release.
The gnocchi resources were outdated. This updates them to match what was released with Yoga.
The existing meters were outdated. This brings them up to date with the yoga release.
This removes some complexity that the original helm chart introduced which defines custom meter sinks relating to instance cpu, disk, and net metrics. We may find ourselves disabling pollsters for individual instances, so let's not inundate the pipeline with un-necessary complexity yet. If we find they are useful or needed, we can re-enable them after verifying their proper operation. The polled metrics will still be stored in Gnocchi, just not transformed according to the defined sinks. Iff re-introduced, these pipeline sinks may need to be further tweaked to work with the updated event defs.
This should make Gnocchi more reliable and have better overall perf.
We don't enforce pod resource limits in other helm charts so set this to false as the default.
Ceilometer no longer has a rest API so let's remove this section from the overrides.
When troubleshooting, it helps to raise or lower default log levels of specific modules, setting requests related loggers to DEBUG for example can help one diagnose ceilometer CRUD operations.
The default was midnight but a lot of jobs run then; kick this off a little later to help avoid the thundering herd affect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overrides for the Ceilometer helm chart, making changes to Gnocchi and/or PostgreSQL charts as needed during integration.
Ceilometer provides metering, monitoring, and alarming capabilities in Openstack for billing, performance, optimization, and capacity planning purposes.