Adds loki helm install examples #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblument
force-pushed
the
loki-helm-configs
branch
2 times, most recently
from
07aed7d to
b44e09c
Compare
cloudnull
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
This is great. I have two nits.
Can you add a doc for loki in the infrastructure section, something that kinfa follows what we have for Prometheus.
One other request, I'd like to see this generate a workflow as well. Something similar to what's found here: https://github.com/rackerlabs/genestack/blob/main/.github/workflows/kustomize-prometheus.yaml
sulochan
reviewed
Mar 8, 2024
cblument
force-pushed
the
loki-helm-configs
branch
from
c2f7189 to
682ed27
Compare
Signed-off-by: Chris Blumentritt <[email protected]>
By default loki helm chart stores the config in a ConfigMap. For backends that require credentials this is unsafe. Setting the `configStorageType` to secret will store the entire loki config in a Secret. Signed-off-by: Chris Blumentritt <[email protected]>
Signed-off-by: Chris Blumentritt <[email protected]>
cblument
force-pushed
the
loki-helm-configs
branch
from
682ed27 to
6c7d3d3
Compare
cloudnull
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.