Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AXM-288] Change response to represent Future assignments the s… #2545

Conversation

KyryloKireiev
Copy link

Description

Change response to represent Future assignments the same way as past assignments. Now past_assignments and future_assignments contains array with student's assignments.

YouTrack

https://youtrack.raccoongang.com/issue/AXM-288

@KyryloKireiev KyryloKireiev requested a review from monteri April 19, 2024 13:05
@KyryloKireiev KyryloKireiev self-assigned this Apr 19, 2024
lms/djangoapps/mobile_api/users/serializers.py Outdated Show resolved Hide resolved
Comment on lines 270 to 272
next_assignment_all = []
next_assignment = []
past_assignment = []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
next_assignment_all = []
next_assignment = []
past_assignment = []
future_assignments = []
past_assignments = []

Change names a bit: plural for both and future_assignments

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next_assignments will be initialized later

@monteri monteri force-pushed the kireiev/feat/AXM-288/Update_course_assignments_getting_logic branch from 0020773 to 2c97b05 Compare April 24, 2024 08:06
@monteri monteri force-pushed the kireiev/feat/AXM-288/Update_course_assignments_getting_logic branch from 2c97b05 to d12b0a5 Compare April 24, 2024 08:15
@monteri monteri merged this pull request into mob-develop Apr 24, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants