feat: [AXIMST-584] create view for course navigation sidebar #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlugovGrGlib
reviewed
Mar 7, 2024
| @@ -19,7 +19,8 @@ class CourseBlockSerializer(serializers.Serializer): | |||
| def get_blocks(self, block): # pylint: disable=missing-function-docstring | |||
| block_key = block['id'] | |||
| block_type = block['type'] | |||
| children = block.get('children', []) if block_type != 'sequential' else [] # Don't descend past sequential | |||
| last_parent_block_type = 'vertical' if self.context.get('include_vertical') else 'sequential' | |||
| children = block.get('children', []) if block_type != last_parent_block_type else [] # Don't descend past sequential | |||
There was a problem hiding this comment.
The comment seems not to be valid anymore?
|
@NiedielnitsevIvan Do you think we can already create unit tests for the view, or it can be problematic because of the optimization changes in the follow up tasks? Additionally, please fix the pylint check |
@GlugovGrGlib |
GlugovGrGlib
approved these changes
Mar 7, 2024
NiedielnitsevIvan
force-pushed
the
Ivan_Niedielnitsev/AXIMST-584/feature/Create-endpoint-providing-Course-structure-for-sidebar
branch
from
ad97067 to
0ccb71e
Compare
monteri
approved these changes
Mar 12, 2024
GlugovGrGlib
pushed a commit
that referenced
this pull request
Mar 15, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
ruzniaievdm
pushed a commit
that referenced
this pull request
Mar 28, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
ruzniaievdm
pushed a commit
that referenced
this pull request
Apr 4, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
monteri
pushed a commit
that referenced
this pull request
Apr 10, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
GlugovGrGlib
pushed a commit
that referenced
this pull request
Apr 12, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
monteri
pushed a commit
that referenced
this pull request
Apr 17, 2024
* feat: [AXIMST-584] create view for course navigation sidebar * test: [AXIMST-584] add tests for CourseSidebarBlocksView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-584 [BE] Create endpoint providing Course structure for sidebar