feat: [AXIMST-111] create API for course textbooks #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/textbook-api-drf
branch
from
9d40db4 to
81f6cca
Compare
monteri
reviewed
Jan 9, 2024
Comment on lines
63
to
74
| "tab_title": "Textbook Name", | ||
| "chapters": [ | ||
| { | ||
| "title": "Chapter 1", | ||
| "url": "/static/Present_Perfect.pdf" | ||
| }, | ||
| { | ||
| "title": "Chapter 2", | ||
| "url": "/static/Lear.pdf" | ||
| } | ||
| ], | ||
| "id": "Textbook_Name" |
There was a problem hiding this comment.
nit: should be tabbed to the right
| Serializer for representing course's textbooks. | ||
| """ | ||
|
|
||
| textbooks = serializers.ListField() |
There was a problem hiding this comment.
I guess it should be
Suggested change
| textbooks = serializers.ListField() | |
| textbooks = CourseTextbookItemSerializer(many=True) |
right?
There was a problem hiding this comment.
Yes, it is possible
But I used the same format as i was in previous API's, dict instead of list
There was a problem hiding this comment.
Maybe this was intentional, idk
ruzniaievdm
force-pushed
the
ruzniaievdm/feat/textbook-api-drf
branch
from
81f6cca to
90ff1d1
Compare
monteri
pushed a commit
that referenced
this pull request
Jan 10, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
monteri
pushed a commit
that referenced
this pull request
Jan 15, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
monteri
pushed a commit
that referenced
this pull request
Jan 18, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
monteri
pushed a commit
that referenced
this pull request
Jan 24, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
monteri
pushed a commit
that referenced
this pull request
Jan 30, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
ruzniaievdm
added a commit
that referenced
this pull request
Feb 22, 2024
* feat: [AXIMST-111] create API for course textbooks * fix: add tabulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXIMST-111