add try catch

rabbit-php · Jun 22, 2020 · 9ad39bb · 9ad39bb
1 parent c1f38b8
commit 9ad39bb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/src/core/Timer.php b/src/core/Timer.php
@@ -51,16 +51,14 @@ public static function addTickTimer(string $name, float $time, callable $callbac
     {
         self::checkTimer($name);
         $channel = new Channel(1);
-        $tid = rgo(function () use ($name, $channel, $callback, $time, $params) {
-            while (true) {
-                if ($ret = $channel->pop($time / 1000)) {
-                    continue;
-                }
-                rgo(function () use ($name, $callback, $params) {
-                    self::$timers[$name]['count']++;
-                    call_user_func($callback, ...$params);
-                });
+        $tid = goloop(function () use ($name, $channel, $callback, $time, $params) {
+            if ($ret = $channel->pop($time / 1000)) {
+                return;
             }
+            rgo(function () use ($name, $callback, $params) {
+                self::$timers[$name]['count']++;
+                call_user_func($callback, ...$params);
+            });
         });
         self::$timers[$name] = ['name' => $name, 'chan' => $channel, 'tid' => $tid, 'type' => self::TYPE_TICKET, 'count' => 0];
         return $tid;

diff --git a/src/core/TimerCo.php b/src/core/TimerCo.php
@@ -3,7 +3,9 @@
 namespace rabbit\core;
 
 use Co\System;
+use rabbit\App;
 use rabbit\contract\AbstractTimer;
+use rabbit\helper\ExceptionHelper;
 
 /**
  * Class TimerCo
@@ -51,8 +53,14 @@ public static function addTickTimer(string $name, float $time, callable $callbac
         self::$timers[$name] = ['name' => $name, 'type' => self::TYPE_AFTER];
         $tid = rgo(function () use ($name, $callback, $time, $params) {
             while (isset(self::$timers[$name])) {
-                call_user_func($callback, ...$params);
-                System::sleep($time / 1000);
+                try {
+                    call_user_func($callback, ...$params);
+                } catch (\Throwable $exception) {
+                    App::info($exception->getMessage());
+                    print_r(ExceptionHelper::convertExceptionToArray($throwable));
+                } finally {
+                    System::sleep($time / 1000);
+                }
             }
         });
         self::$timers[$name]['tid'] = $tid;