Corrections and Mute option added #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix for the buffer bug in the method adjustBuffer.
Remove previously commented line.
Correction for the bug in the player showing a black screen.
Fix/temp buffer fix
Added mute boolean to save or not video with audio.
Mute boolean property added.
Feature/add mute
| @@ -54,6 +54,11 @@ | |||
| @property (readonly, nonatomic) BOOL isRecording; | |||
|
|
|||
| /** | |||
| If true the SCRecorder will only record video, not audio | |||
| */ | |||
| @property (nonatomic) BOOL mute; | |||
There was a problem hiding this comment.
You can already do this by disabling the audio in audioConfiguration
There was a problem hiding this comment.
Can you post a snippet code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections for the audio buffer bug #249 and the bug #238.
Added new feature for mute during video recording.