Synthesis Lengths #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/r9y9/wavenet_vocoder#4-synthesize-from-a-checkpoint
Well, that was intentional, though. Do you happen to need |
|
Yeah. I did read the description. Given that it takes 20 - 40 minutes at a time to synthesize, I needed the length option just to get a sample from a checkpoint quickly. |
r9y9
requested changes
May 20, 2018
| @@ -7,7 +7,7 @@ | |||
| options: | |||
| --hparams=<parmas> Hyper parameters [default: ]. | |||
| --preset=<json> Path of preset parameters (json). | |||
| --length=<T> Steps to generate [default: 32000]. | |||
There was a problem hiding this comment.
If we drop the default parameter then I don' think
Line 146 in 2b557d4
will work, since None cannot be converted to int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditional synthesis does not respect the lengths parameter, rather it overrides it. This patch fixes that.