Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for EVM contract calls by enhancing the
interface
macro with 2 args (both optional from the user pov):fn set(&mut self, value: U256)
would be hashed from:set(uint256)
on "evm"set
on "r55"tested by manually loading the bytecode of a simple storage contract written in foundry to test x-contract calls in both directions:
i believe that this proves that the execution changes made on:
were enough to fully support cross contract calls, but happy to test more scenarios if needed (remember that @leonardoalt questioned whether the changes would be enough or not, so maybe worth increasing test coverage even more)
open questions:
BASE
determined by the riscv emulator, so i forced a minimum size of 32bytes for the time being: