Introduce capability to retry when upload fails, up to the given maxRetriesForUpload parameter #193
Conversation
| while (retries >= 0) { | ||
| try { | ||
| await pTimeout( | ||
| runUpload( |
There was a problem hiding this comment.
If this fails part-way through, it will leave a dangling edit. We probably need to do a retry around each request, and try to discard the edit on fail
There was a problem hiding this comment.
Oufff, maybe I bit off more than I could chew. Not familiar with Google Play's API and how the edits work. Will try to take another stab tomorrow after work, getting late here! Thanks for the code review!
There was a problem hiding this comment.
No worries! Thanks for taking the time to look at this :)
|
Hey @Abushawish, did you get a chance to revisit this? |
|
please merge this. |
As per above, it is not ready to be merged |
|
Hey @Abushawish, just checking in again. Are you still interested in completing this work? |
|
I will assume not. I'll take over this when I have some time |
|
Closing this to keep the PR list clean |
This a PR to try and work around issue #188 by retrying the upload until either a success or the max retry number is reached.
It matches the workaround of Fastlane for this issue where they simply reattempt until success or the max retry number is reached, see here.