Drop encoding = "UTF-8" for JSON in all places #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jannes-m any comments about this extension? |
|
@florisvdh, I am sorry for being so unresponsive the last week. I'll have a look this evening! |
jannes-m
approved these changes
Sep 15, 2024
|
I'll merge this into my PR and if you are happy you can merge it into main -:) |
|
No problem of course. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
processx::run()supports UTF-8 characters in all system locales (see PR #219). Also, it was observed that {qgisprocess} doesn't work successfully in non-UTF-8 locales (#218). Relaxing the UTF-8 requirement in someqgis_run()statements (those that set theencodingargument) appears to circumvent this (see #218 and PR #219), even while JSON is UTF-8 by definition.This PR amends PR #219.
We'll see whether this would pose new problems; as of now none have been found (tests done locally in Linux Mint & Windows).