-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop {rematch2}
dependency
#1011
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 91.14% 91.20% +0.05%
==========================================
Files 46 46
Lines 2664 2682 +18
==========================================
+ Hits 2428 2446 +18
Misses 236 236
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Can you relax the failing test a bit? I.e. it does not have to be 5 times faster, 4x is also enough I think. |
Yeah, licence I also checked but both are MIT, so should be fine. |
Done. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5b69525 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Related to #1010