Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop {rematch2} dependency #1011

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Drop {rematch2} dependency #1011

merged 4 commits into from
Sep 28, 2022

Conversation

IndrajeetPatil
Copy link
Collaborator

Related to #1010

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #1011 (8382599) into main (35519b9) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
+ Coverage   91.14%   91.20%   +0.05%     
==========================================
  Files          46       46              
  Lines        2664     2682      +18     
==========================================
+ Hits         2428     2446      +18     
  Misses        236      236              
Impacted Files Coverage Δ
R/rules-spaces.R 98.34% <100.00%> (ø)
R/utils.R 93.47% <100.00%> (+4.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lorenzwalthert
Copy link
Collaborator

Can you relax the failing test a bit? I.e. it does not have to be 5 times faster, 4x is also enough I think.

@lorenzwalthert
Copy link
Collaborator

Yeah, licence I also checked but both are MIT, so should be fine.

@IndrajeetPatil
Copy link
Collaborator Author

Can you relax the failing test a bit?

Done.

@IndrajeetPatil IndrajeetPatil merged commit f46c4c2 into r-lib:main Sep 28, 2022
@IndrajeetPatil IndrajeetPatil deleted the 1010_rm_rematch2 branch September 28, 2022 07:27
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 5b69525 is merged into main:

  •   :ballot_box_with_check:cache_applying: 29.7ms -> 29.9ms [-0.33%, +1.23%]
  •   :ballot_box_with_check:cache_recording: 813ms -> 810ms [-1.45%, +0.74%]
  •   :ballot_box_with_check:without_cache: 2s -> 2s [-0.42%, +0.39%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants