Support hyperlinks in spreadsheets similar to Spreadsheet::ParseExcel #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is rough and ready but works for me with the file I have
This is based upon TestActiveSheet.xls in the Spreadsheet::ParseExcel distribution
This is based upon test 47_hyperlinks.t in Spreadsheet::ParseExcel
Here I was trying to match a return value in the Spreadsheet::ParseExcel test but actually lets just make this a todo test for now as otherwise I'm potentially opening up to pitfalls
Per previous commit stop trying to frig values without really understanding what's going on
Match other test files
They are ok on my machine but the version on github seems to have \r in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.