Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump-qwik #234

Closed
wants to merge 2 commits into from
Closed

Bump-qwik #234

wants to merge 2 commits into from

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Aug 11, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Installing qwik 1.8.0 fails on qwik-ui. This could potentially solve the issue 🤷

Edit:

The error we're getting is coming from qwik-nx, either when updating to qwik 1.8.0 or to nx 19.5.7:

TypeError: Cannot read properties of undefined (reading 'push')
at /home/runner/work/qwik-ui/qwik-ui/node_modules/.pnpm/[email protected]_bawxiklc23p3w752und6s6mtmi/node_modules/qwik-nx/src/plugins/qwik-nx-vite.plugin.js:36:47
at Generator.next ()
at fulfilled (/home/runner/work/qwik-ui/qwik-ui/node_modules/.pnpm/[email protected]/node_modules/tslib/tslib.js:166:62)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

it's trying to push on vendorRoots but it seems that vendorRoots is undefined.

Use cases and why

    1. One use case
    1. Another use case

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@dmitry-stepanenko
Copy link
Contributor

dmitry-stepanenko commented Aug 11, 2024

Hey @maiieul , you're bumping only the dev dependency that is only being used inside of this repository. You could bump the peer dependency, but I doubt it will help much, because this project does not really rely on qwik code for anything

I'll be around in roughly an hour, will ping you in discord so we can discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants