Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace default port #195

Merged
merged 8 commits into from
Sep 18, 2023
Merged

replace default port #195

merged 8 commits into from
Sep 18, 2023

Conversation

JulianTurner
Copy link
Contributor

@JulianTurner JulianTurner commented Sep 2, 2023 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Changed the default Port from 4200 to 5173

#121

@JulianTurner JulianTurner marked this pull request as ready for review September 2, 2023 12:53
@dmitry-stepanenko
Copy link
Contributor

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

@JulianTurner
Copy link
Contributor Author

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

@dmitry-stepanenko
Copy link
Contributor

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

thanks a lot! looks like you also have to run nx run qwik-nx:test -u in order to update snapshots, because CI is failing

@JulianTurner
Copy link
Contributor Author

Hey @JulianTurner, thank you for the PR! Do you mind also switching the preview port from 4300 to 4173 https://github.com/qwikifiers/qwik-nx/blob/main/packages/qwik-nx/src/generators/application/utils/normalize-options.ts#L53 ?

Sure, I just pushed a update

thanks a lot! looks like you also have to run nx run qwik-nx:test -u in order to update snapshots, because CI is failing

Thanks for the insight, this is running now :-)

dmitry-stepanenko
dmitry-stepanenko reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JulianTurner, I've checked your branch locally, please fix 2 comments I left below and I think we'll be able to merge

e2e/qwik-nx-e2e/tests/micro-frontends.spec.ts Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@JulianTurner
Copy link
Contributor Author

@dmitry-stepanenko Updated as mentioned

@dmitry-stepanenko dmitry-stepanenko merged commit c5e0eda into qwikifiers:main Sep 18, 2023
2 checks passed
@dmitry-stepanenko
Copy link
Contributor

yay, merged 🎉 thanks for this!

@dmitry-stepanenko dmitry-stepanenko mentioned this pull request Sep 18, 2023
Closed
@JulianTurner
Copy link
Contributor Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-stepanenko dmitry-stepanenko Awaiting requested review from dmitry-stepanenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulianTurner @dmitry-stepanenko