Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOI links #107

Closed
wants to merge 2 commits into from
Closed

Update DOI links #107

wants to merge 2 commits into from

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Oct 9, 2024

No description provided.

@nwlambert
Copy link
Member

still failing? if aps uses cloudflare it might be an issue? gaurav-nelson/github-action-markdown-link-check#185

@BoxiLi
Copy link
Member Author

BoxiLi commented Oct 9, 2024

Looks like it is not just a DOI problem,

https://journals.aps.org/prb/abstract/10.1103/PhysRevB.94.201407

also fails in v5...

Also not all the DOI links to Phsycal review fail. Only some of them... BY replacing dx.doi.org to doi.rog I generate more errors in v5...

@BoxiLi
Copy link
Member Author

BoxiLi commented Oct 9, 2024

Should we add 403 to the list of successful?

Maybe @hodgestar have some opinions on this?

@hodgestar
Copy link
Contributor

My opinion is that these robot checks are becoming increasingly annoying. :)

We could try https://github.com/UmbrellaDocs/linkspector ?

@BoxiLi BoxiLi closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants