Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved allowed params into json file. #113

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

THuckemann
Copy link
Collaborator

Allowed parameters are not defined in the measurement script class and the Terminal class anymore. Instead, they are loaded from all json files located in \src\qumada\instrument\parameter_whitelists\param_whitelist.json. It is possible to add custom files with own whitelisted parameter names.

@THuckemann THuckemann added enhancement New feature or request backlog Off the current roadmap labels Nov 22, 2024
@THuckemann THuckemann self-assigned this Nov 22, 2024
Copy link

github-actions bot commented Nov 22, 2024

Test Results

  4 files  ±0    4 suites  ±0   10s ⏱️ -1s
 25 tests ±0   25 ✅ ±0  0 💤 ±0  0 ❌ ±0 
100 runs  ±0  100 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4065ca0. ± Comparison against base commit ef4f4b2.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 22.53%. Comparing base (ef4f4b2) to head (4065ca0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/qumada/measurement/device_object.py 0.00% 2 Missing ⚠️
src/qumada/measurement/measurement.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   22.32%   22.53%   +0.21%     
==========================================
  Files          38       38              
  Lines        4627     4641      +14     
==========================================
+ Hits         1033     1046      +13     
- Misses       3594     3595       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@THuckemann THuckemann merged commit e13dc6a into main Nov 22, 2024
9 checks passed
@THuckemann THuckemann deleted the feature/parameter_whitelists branch November 22, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Off the current roadmap enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants