Html workaround #13
Merged
Html workaround #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce the ability to change end position/start position. This will be helpful if we decide to remove overlaps in this way
The html exporter used substrings to apply rules to the html output. If there was an overlap then the parts of the substring may repeat. No matter what the exporter, there would always be a need to handle overlaps. Overlaps happen frequently with ghunna vs idghaam vs meem idghaam see issue #11. In this workaround, overlaps are removed all together. Also, ghunna is given the least preference and is always removed. Doing this at the sorting level will help remove the need of handling this in any future exporters. .
|
sounds good, let's do this for now and, in the future insha'Allah, we can do something more formal (ex each rule has a rank value and we only take the top ranked item). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Html exporter is broken because of possibility of overlapping rules. This will fix #11 since overlapping entries are removed/modified. Look at individual commits for more details.